--- vice-1.22.8/src/arch/win32/uilib.c	2007-08-19 18:07:36 +0200
+++ vice-1.22.8_ian/src/arch/win32/uilib.c	2008-02-06 14:09:01 +0100
@@ -582,7 +582,7 @@
             pattern_len = (_tcslen(uilib_filefilter[i].pattern) + 1) * sizeof(TCHAR);
             filter = lib_realloc(filter, current_len + name_len + pattern_len);
-            memcpy(filter + name_len + pattern_len, filter, current_len);
-            memcpy(filter, translate_text(uilib_filefilter[i].name), name_len);
-            memcpy(filter + name_len, uilib_filefilter[i].pattern, pattern_len);
+            memmove(filter + name_len + pattern_len, filter, current_len);
+            memmove(filter, translate_text(uilib_filefilter[i].name), name_len);
+            memmove(filter + name_len, uilib_filefilter[i].pattern, pattern_len);
             current_len += name_len + pattern_len;
         }

            0x78        IDM_DATASETTE_CONTROL_REWIND        F9    # VK_F9
            0x79        IDM_DATASETTE_CONTROL_FORWARD       F10   # VK_F10
ALT         0x7A        IDM_DATASETTE_RESET_COUNTER         F11   # ALT|VK_F11
            0x7A        IDM_DATASETTE_CONTROL_STOP          F11   # VK_F11
            0x7B        IDM_DATASETTE_CONTROL_START         F12   # VK_F12
ALT         0x7B        IDM_DATASETTE_CONTROL_RECORD        F12   # ALT|VK_F12

ALT         0x78        IDM_DATASETTE_CONTROL_REWIND        F9    # VK_F9
ALT         0x79        IDM_DATASETTE_CONTROL_FORWARD       F10   # VK_F10
ALT|CTRL    0x7A        IDM_DATASETTE_RESET_COUNTER         F11   # ALT|VK_F11
ALT         0x7A        IDM_DATASETTE_CONTROL_STOP          F11   # VK_F11
ALT         0x7B        IDM_DATASETTE_CONTROL_START         F12   # VK_F12
ALT|CTRL    0x7B        IDM_DATASETTE_CONTROL_RECORD        F12   # ALT|VK_F12

# dont work, IDC* not usable ;)
#ALT         0x70        IDC_SID_6581                F1      # VK_F1
#ALT         0x71        IDC_SID_8580                F2      # VK_F2

      case IDC_SID_6581 | 0x00010000:
        resources_set_int("SidModel", 0);
        break;
      case IDC_SID_8580 | 0x00010000:
        resources_set_int("SidModel", 1);
        break;

ALT         '7'         IDM_AUTOSTART
ALT         '2'         IDM_TOGGLE_DRIVE_TRUE_EMULATION
ALT         '3'         IDM_TOGGLE_VIRTUAL_DEVICES
ALT         'P'         IDM_TOGGLE_FASTPAL

1)
menu Edit should be activated by D and not E, which is already Settings

POPUP "&Edit"
in *.rc should be
POPUP "E&dit"

==============================================================================
2)
default keys for copy/paste clash with valid C64 keycombos, being CTRL
mapped as C= we can't use C=+C C=+V C=+Lira
In win_shortcuts.vsc better use some ALT combos

# Alt+Ins / Alt-Del are good enough for me
ALT         0x2E        IDM_EDIT_COPY                       # VK_DELETE
ALT         0x2D        IDM_EDIT_PASTE                      # VK_INSERT

==============================================================================
3)
SHIFT key must be added in uikeyboard.c
---------8<------------8<------------8<------------8<------------8<---
--- win32/uikeyboard.c	2008-07-18 15:26:20 +0000
+++ win32_patch/uikeyboard.c	2008-07-18 14:24:05 +0000
@@ -306,4 +306,6 @@
                     if (strstr(strlwr(metastr), "alt") != NULL)
                         accel.fVirt |= FALT;
+                    if (strstr(strlwr(metastr), "shift") != NULL)
+                        accel.fVirt |= FSHIFT;

                     if (keystr[0] == '\'' && keystr[2] == '\'') {
@@ -324,6 +326,7 @@
                     if (displaystr != NULL) {
                         p = util_concat("\t",
+                                    ((accel.fVirt & FSHIFT  ) ? "Shift+" : ""),
                                     ((accel.fVirt & FCONTROL) ? "Ctrl+" : ""),
-                                    ((accel.fVirt & FALT) ? "Alt+" : ""),
+                                    ((accel.fVirt & FALT    ) ? "Alt+"   : ""),
                                     displaystr, NULL);
---------8<------------8<------------8<------------8<------------8<---
==============================================================================
4)
to allow any keyboard event, in ui.c wparam must be PASSED & 0xffff to
various functions. Else these can't be used in win_shortcuts.vsc
IDM_SID_SETTINGS
IDM_DATASETTE_CONTROL_START
and so on
---------8<------------8<------------8<------------8<------------8<---
--- win32/ui.c	2008-07-18 15:26:19 +0000
+++ win32_patch/ui.c	2008-07-18 13:06:27 +0000
@@ -1166,6 +1166,6 @@
     if (ui_machine_specific)
         ui_machine_specific(wparam, hwnd);
-
-    switch (wparam & 0xffff) {
+    wparam &= 0xffff; /* fix: iAN */
+    switch ( wparam ) {
       case IDM_DEVICEMANAGER:
       case IDM_FORMFEED_PRINTERIEC4:
---------8<------------8<------------8<------------8<------------8<---


---------8<------------8<------------8<------------8<------------8<---
--- win32/c64ui.c	2008-04-14 19:47:33 +0000
+++ win32_patch/c64ui.c	2008-07-18 16:01:39 +0000
@@ -139,5 +139,5 @@
 {
     uic64cart_proc(wparam, hwnd);
-
+    wparam &= 0xffff;
     switch (wparam) {
       case IDM_VICII_SETTINGS:
---------8<------------8<------------8<------------8<------------8<---

==============================================================================
5)
in win_shortcuts.vsc should be made clear that single keys are configurable
just by using anything (for example KEY) in first column, example

# Syntax
# First column: Combination of ALT|CTRL|SHIFT (or KEY for unshifted keys)
#   to hold for the shortcut
[...]

I've successfully added these

KEY         0x78        IDM_DATASETTE_CONTROL_REWIND        F9    # VK_F9
KEY         0x79        IDM_DATASETTE_CONTROL_FORWARD       F10   # VK_F10
KEY         0x7A        IDM_DATASETTE_CONTROL_STOP          F11   # VK_F11
KEY         0x7B        IDM_DATASETTE_CONTROL_START         F12   # VK_F12
ALT         0x7A        IDM_DATASETTE_RESET_COUNTER         F11   # ALT|VK_F11
ALT         0x7B        IDM_DATASETTE_CONTROL_RECORD        F12   # ALT|VK_F12
==============================================================================
6)
Additional Events for changing SID models by keyboard shortcut.
Something like this (not working)


--- win32/ui.c	2008-07-18 15:26:19 +0000
+++ win3_patch2/ui.c	2008-07-18 13:06:27 +0000
@@ -1343,4 +1343,12 @@
         ui_display_statustext(translate_text(IDS_SOUND_RECORDING_STOPPED), 1);
         break;
+      /* to be implemented! */
+      case IDC_SID_6581 :
+        resources_set_int("SidModel", 0);
+        break;
+      case IDC_SID_8580 :
+        resources_set_int("SidModel", 1);
+        break;
+
       default:
         handle_default_command(wparam, lparam, hwnd);